Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Fixed bug with zero depth ur_rect_region which must be checked before calling func #17681

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[UR] Fixed bug with zero depth ur_rect_region which must be checked before calling func #17681

wants to merge 1 commit into from

Conversation

GermanAizek
Copy link

Its PR migrated from oneapi-src/unified-runtime#2746
It looks like a common typo when writing functions.

Fixed functions:

  • urEnqueueMemBufferWriteRect()
  • urEnqueueMemBufferReadRect()

@GermanAizek GermanAizek requested a review from a team as a code owner March 27, 2025 14:33
@aarongreig aarongreig changed the title Fixed bug with zero depth ur_rect_region which must be checked before calling func [UR] Fixed bug with zero depth ur_rect_region which must be checked before calling func Mar 27, 2025
@aarongreig
Copy link
Contributor

looks like there're more files the change needs propagating to, the easiest way is to run the generate target or you can check the diff here https://github.com/intel/llvm/actions/runs/14109220584/job/39523495651?pr=17681#step:9:268

@GermanAizek GermanAizek requested a review from a team as a code owner March 29, 2025 13:36
@GermanAizek
[UR] Fixed bug with zero depth rect_region which must be checked before
9cc651d 
Fixed functions:
- urEnqueueMemBufferWriteRect()
- urEnqueueMemBufferReadRect()
@GermanAizek
Copy link
Author

@aarongreig, I fixed all conditions and renamed commit name.

steffenlarsen
steffenlarsen approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBrunton RossBrunton RossBrunton approved these changes

@aarongreig aarongreig aarongreig approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GermanAizek @aarongreig @RossBrunton @steffenlarsen