[UR][CUDA][HIP] Cleanup adapter code #18370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmiller
force-pushed
the
cuda-hip-cleanups
branch
from
9774f55 to
954e22e
Compare
jchlanda
approved these changes
May 12, 2025
| if (Ret != hipSuccess && Ret != hipErrorNotFound) | ||
| UR_CHECK_ERROR(Ret); | ||
| return mapErrorUR(Ret); | ||
|
|
||
| if (Ret == hipErrorNotFound) { |
There was a problem hiding this comment.
This is a nit, but if we check for hipErrorNotFound first, we wouldn't need to re-check for it in the second if. Maybe tying them into if/else if would be nicer?
s/that that/that In the commit message :) |
- Inline createProgram function in CUDA adapter, and catch ur result exceptions in both adapters. - Fix pattern of unnecessarily storing error code in a variable instead of just returning it. - Fix incorrect setErrorMessage uses, the adapter specific code signals that that there is a specific error code and message in get last error, it doesn't make sense to use it as the code in the last error. - Remove now unrelated comment on now removed primary context extension. - Don't use `unique_ptr` when `delete` is enough.
npmiller
force-pushed
the
cuda-hip-cleanups
branch
from
954e22e to
475ac44
Compare
przemektmalon
approved these changes
May 12, 2025
|
@intel/llvm-gatekeepers this is ready to merge, failure unrelated and tracked here: #18416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique_ptrwhendeleteis enough.