[libspirv][remangler] Remangle pointer address space when target's default addrspace is private #18383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault addrspace is private For target where default address space is private, pointer address space mangling in libclc is not compatible with SYCL mangling. Take spir64 target as example, OpenCL mangling: _Z17__spirv_ocl_fractfPU3AS4f(float, ptr addrspace(4)) _Z17__spirv_ocl_fractfPf(float, ptr) SYCL mangling: _Z17__spirv_ocl_fractfPf(float, ptr addrspace(4)) _Z17__spirv_ocl_fractfPU3AS0f(float, ptr) This leads to issue when linking libclc built-ins to SYCL device code. This PR fixes the issue by remangling libclc built-ins to align with SYCL: Remangle _Z17__spirv_ocl_fractfPU3AS4f to _Z17__spirv_ocl_fractfPf. Remangle _Z17__spirv_ocl_fractfPf to _Z17__spirv_ocl_fractfPU3AS0f. Relates to intel#16703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For target where default address space is private, pointer address space mangling in libclc is not compatible with SYCL mangling. Take spir64 target as example,
OpenCL mangling:
_Z17__spirv_ocl_fractfPU3AS4f(float, ptr addrspace(4))
_Z17__spirv_ocl_fractfPf(float, ptr)
SYCL mangling:
_Z17__spirv_ocl_fractfPf(float, ptr addrspace(4))
_Z17__spirv_ocl_fractfPU3AS0f(float, ptr)
This leads to issue when linking libclc built-ins to SYCL device code. This PR fixes the issue by remangling libclc built-ins to align with SYCL: Remangle _Z17__spirv_ocl_fractfPU3AS4f to _Z17__spirv_ocl_fractfPf. Remangle _Z17__spirv_ocl_fractfPf to _Z17__spirv_ocl_fractfPU3AS0f.
Relates to #16703