[SYCL] Add STL wrapper for corecrt.h and define _invalid_parameter
as SYCL_EXTERNAL
#18400
+50
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #18213, but this PR addresses failures in SYCL benchmarks for sgemm and the "histogram" sample in oneAPI-samples on Windows due to device code calling
_invalid_parameter
from MSVC's STL. Example failure is from histograms example in oneAPI-samples:This PR wraps
corecrt.h
and addsSYCL_EXTERNAL
to_invalid_parameter
during device code pass, in order to allow device code to use_invalid_parameter
.