[WIP] Defer arg extraction until handler::finalize #18413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+202
to
+206
| // Store information about the kernel arguments. | ||
| void *MKernelFuncPtr = nullptr; | ||
| int MKernelNumArgs = 0; | ||
| detail::kernel_param_desc_t (*MKernelParamDescGetter)(int) = nullptr; | ||
| bool MKernelIsESIMD = false; |
There was a problem hiding this comment.
I wonder if we can just keep that inside HostKernel class.
There was a problem hiding this comment.
Probably? My original hope here was that we could get rid of HostKernel, but I didn't appreciate that we need it in order to extend the lifetime of the kernel function until handler::finalize is called.
I'm going to focus on getting a version of things that works and demonstrates the optimizations, but once I reach that point I'm open to talking about where the variables should go.
Rather than extracting arguments from the lambda when the kernel is enqueued, store a pointer to the lambda alongside relevant information from the integration header or compiler builtins. Storing this information will allow us to defer the extraction of arguments until we reach handler::finalize(), at which point it may be possible to set the kernel arguments directly without populating MArgs. Signed-off-by: John Pennycook <[email protected]>
Pennycook
force-pushed
the
defer-extract-args
branch
from
a22ad96 to
172d504
Compare
|
I'm not planning to merge this yet, but for my own notes: the only tests failing here are the ones in #18416. |
|
I've folded this into #18387, so closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant number of tests are failing in #18387, so I'm trying something simpler first. The aim of this PR is to defer the extraction of arguments from a lambda until
handler::finalize()is called. If this works, then we can move to optimizing the extraction of arguments as a second step.