Skip to content

set public header include dir for fixing header prefix #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhlee525
Copy link
Contributor

In the previous PR(#297), the install directory for cbor.h was changed to tinycbor/cbor.h.

it causes problem when using FetchContent, since it import headers directly from the source code. (It actually placed in src/tinycbor.h).

I created a dedicated public header directory include by convention, and placed include/tinycbor/cbor.h.

Since all source files reference just cbor.h, I have to updated all include paths accordingly.

I checked tests and tools are able to compile, but not tested for all option sets.

Apologies for the big changes, If you prefer not to adopt this change, feel free to revert #297.

Copy link
Member

@thiagomacieira thiagomacieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like not having the header file right next to the sources. Can you keep the cbor.h header exactly where it is, but instead add include/tinycbor/cbor.h

#include "../../src/cbor.h"

?

Why does everything else need changing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants