Fix issue45 - support for serviceAccount in slurm jobs #887
antoinetranlint.yml
on: pull_request
lint
1m 5s
Check duplicated code
7s
Annotations
10 errors and 2 notices
|
lint:
pkg/interlink/api/func.go#L143
SA1019: retrievedData.EmptyDirs is deprecated: EmptyDirs should be built on plugin side. Currently, it holds the DATA_ROOT_DIR/emptydirs/volumeName, but this should be a plugin choice instead, like it currently is for ConfigMaps, ProjectedVolumeMaps, Secrets. (staticcheck)
|
|
lint:
pkg/virtualkubelet/execute.go#L446
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint:
pkg/virtualkubelet/config.go#L7
var-naming: struct field KubernetesApiAddr should be KubernetesAPIAddr (revive)
|
|
lint:
pkg/virtualkubelet/config.go#L8
var-naming: struct field KubernetesApiPort should be KubernetesAPIPort (revive)
|
|
lint:
pkg/virtualkubelet/config.go#L9
var-naming: struct field KubernetesApiCaCrt should be KubernetesAPICaCrt (revive)
|
|
lint:
pkg/virtualkubelet/execute.go#L459
range: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (revive)
|
|
lint:
pkg/virtualkubelet/execute.go#L462
range: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (revive)
|
|
lint:
pkg/virtualkubelet/execute.go#L544
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|
|
lint:
pkg/virtualkubelet/execute.go#L654
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint
issues found
|
|
Copy/pasted code:
pkg/interlink/api/func.go#L37
see pkg/interlink/api/func.go (54-64)
|
|
Check duplicated code
repository contains 4 duplications.
1 duplications were part of this PR and were annotated
|