Conversation
Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
* added type 36 & 38 * added type 46 * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
* feat: add `thread_name` field in the webhook field * ci: correct from checks. * fixed: Add a missing comma * feat: check exclusive relationship between `thread` and `thread_name` * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
LawMixer
suggested changes
Dec 8, 2024
Contributor
LawMixer
left a comment
LawMixer
left a comment
There was a problem hiding this comment.
Actions have failed the following things by the way - do we safely ignore this?
Member
Author
|
Yeah, the voice tests are unreliable and I still haven't figured out why |
LawMixer
approved these changes
Dec 8, 2024
Contributor
LawMixer
left a comment
LawMixer
left a comment
There was a problem hiding this comment.
Besides those, I've tested on python3.10 and python3.11 and it works normally.
* Feat: Add support for Application Emoji * Fix emoji tests * fix: make sure to await response Original code from #1746, which was closed for some reason. * feat: adjust methods in CustomEmoji to respect app emojis * fix: adjust app emoji code based off testing --------- Co-authored-by: AstreaTSS <25420078+AstreaTSS@users.noreply.github.com>
* feat: add guild_count property * docs: remove incorrect comment Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com>
LordOfPolls
approved these changes
Jan 30, 2025
Contributor
LordOfPolls
left a comment
LordOfPolls
left a comment
There was a problem hiding this comment.
LGTM
Tested and happy. Pytest error appears to be transient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New release soon
But I want #1742 to be merged first.