Require domain parameter for Intercom cookie deletion #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the domain parameter required in both intercom_shutdown_helper and intercom_shutdown methods to ensure proper cookie deletion. Intercom sets cookies with a domain prefix (e.g. ".domain.com"), and we need to match this format when deleting cookies as Chrome/browsers very particular about cookie attributes. If you don't set a specific domain the cookie doesn't get deleted.
Key changes:
This ensures that Intercom cookies are properly cleared during logout.
Note: This will likely be a major version change if we decide to ship it since it's a breaking change.