WEBDEV-7901 Indicate "Weekly" or "All-time" views on tile labels#578
Open
WEBDEV-7901 Indicate "Weekly" or "All-time" views on tile labels#578
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 92.44% 92.45%
=======================================
Files 113 113
Lines 18989 18999 +10
Branches 1381 1385 +4
=======================================
+ Hits 17555 17565 +10
Misses 1404 1404
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On our list and compact-list tiles, we currently update the number of views according to the current sort option. However, on our list and compact-list tiles, this is currently still just labeled "Views" with no indication of which type of views it represents. This PR updates those labels to more precisely indicate whether they represent "Weekly views" or "All-time views".