Update environment of cron service

[jimchamp]

Closes #13108

Attempts to read the config YAML in the cron job container were resulting in PermissionErrors. Adding the OL_CONFIG environment variable to the cron service, then forwarding said variable to cron's environment appears to have solved the issue.

Note that the ol-cron-start.sh changes have not been tested, per se -- I ran echo "OL_CONFIG=/olsystem/etc/openlibrary.yml" >> /etc/environment inside of the container in order to test these changes.

Technical

Testing

Screenshot

Stakeholders

[RayBB]

This is a good solution.
The other thing we could do is have the system just use some default for features if OL_CONFIG isn't set but that probably leaves us in a more fragile state.

[jimchamp]

This will probably be fine -- I'm not sure what a sensible default for features would be.

Will know if this is working in ~10 minutes. If it works, I'll move this out of draft.

[jimchamp]

It did not work. Have verified that OL_CONFIG is set in the container by running echo $OL_CONFIG inside of the container.

[RayBB]

Does it still have the same error? Do you know if the conf yml is in the container?

[jimchamp]

I believe that OL_CONFIG is not being exported at cron startup, and conf/openlibrary.yml is being used as a default. Attempting to verify now.

[Copilot]

Pull request overview

Updates the production cron-jobs container environment so cron-invoked scripts can read the intended Open Library config YAML (via OL_CONFIG), addressing PermissionError failures seen when scripts default to conf/openlibrary.yml (Issue #13108).

Changes:

• Add OL_CONFIG=/olsystem/etc/openlibrary.yml to the cron-jobs service in compose.production.yaml.
• Update docker/ol-cron-start.sh to expose OL_CONFIG to cron by writing it into /etc/environment before starting the daemon.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
docker/ol-cron-start.sh	Forwards OL_CONFIG into cron’s environment via /etc/environment before installing the crontab and starting cron.
compose.production.yaml	Sets OL_CONFIG for the cron-jobs service to point at the production config YAML in /olsystem.

[jimchamp]

Okay, I'm fairly certain that this will fix things now that the variable is being forwarded to cron's environment. We probably won't know for sure until after our next deployment, though.

For now, our cron environment has been updated, and the store counts job is working again.

[RayBB]

Thanks for looking into this one. Sorry about the inconvenience.