Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for null namespace and use pinia #21

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

C-Loftus
Copy link
Member

Refactors to use the composition API and pinia. No visual / template code is different, just state logic.

  • instead of having refs that need to be emitted to the parent, we can use a store. This allows us to access certain variables that are relevant to multiple components that would otherwise be awkward to pass around
    • pinia has a lot of nice features and allows us to just v-model directly with the store value
  • uses the composition API to clean up the code a bit more

@C-Loftus C-Loftus requested a review from webb-ben August 21, 2024 16:53
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for register-geoconnex-us ready!

Name Link
🔨 Latest commit 1370bc9
🔍 Latest deploy log https://app.netlify.com/sites/register-geoconnex-us/deploys/66c61bb329108300086abd8a
😎 Deploy Preview https://deploy-preview-21--register-geoconnex-us.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@webb-ben webb-ben merged commit 823cad2 into main Aug 21, 2024
6 checks passed
@webb-ben webb-ben deleted the fixNullThisError branch August 21, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants