Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1291 - Compare HTTPS redirect hostname, not netloc (incl port) #1293

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix #1291 - Compare HTTPS redirect hostname, not netloc (incl port) #1293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checks/tasks/tls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2998,7 +2998,7 @@ def forced_http_check(af_ip_pair, url, task):
parsed_url = urlparse(response.url)
# Requirement: in case of redirecting, a domain should firstly upgrade itself by
# redirecting to its HTTPS version before it may redirect to another domain (#1208)
if parsed_url.scheme == "https" and url == parsed_url.netloc:
if parsed_url.scheme == "https" and url == parsed_url.hostname:
forced_https = ForcedHttpsStatus.good
forced_https_score = scoring.WEB_TLS_FORCED_HTTPS_GOOD
break
Expand Down
Loading