made windows BLE device disposable to allow control of freeing resources #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michallesniak
suggested changes
Feb 7, 2025
There was a problem hiding this comment.
As this is really important change as this improved the disconnection times on the Windows - you forgot about declaring disposedValue field. Also stick to the style of the class and to the convention and name it _disposedValue, please (or even better - name it _disposed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #446
I pared the code down to just the Windows code when i forked this to get it working in my other code, so not sure if applying the
IDisposablethe way I did makes the other OS's happy.