setup: replace isbnlib with isbnlib2#140
Merged
Merged
Conversation
tmorrell
approved these changes
May 22, 2026
tmorrell
left a comment
tmorrell
left a comment
Contributor
There was a problem hiding this comment.
Looks like a very sensible change to a maintained version of the library
slint
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in xlcnd/isbnlib#143, the library has not been updated for some time, and masking can be wrong for some ISBN.
For instance,
isbnlib.mask("9798991050005")returns:'979-8--99105000-5'withisbnlibversion3.10.14'979-8-9910500-0-5'withisbnlib2version3.11.7Also fixes #135 where
isbnlib.mask("9791370064242")returns:''withisbnlibversion3.10.14'979-13-7006-424-2'withisbnlib2version3.11.7Requiring a minimum version of
3.11.7since this is the last version supporting Python3.9(version3.11.8requires Python3.10).Licenses:
isbnlibis LGPLv3isbnlib2is LGPL-3.0-or-later