-
Notifications
You must be signed in to change notification settings - Fork 79
Fixes lingering issues to support workspaces in CLI #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/dart_custom_lint~336 Documentation is deployed and generated using docs.page. |
Hello there! We'll need tests, as per usual :) |
I am trying to write a test, but having a hard time getting it to work. This PR is more of a refactor than added functionality. The only code that might be questionable is adding |
Well if it's fixing something, we need a regression test for it. |
Do you have any suggestions for where the test should go and other tests I should base it on? |
Depends on how you want to implement the test. I'm not fully understanding the issue that is being fixed here, so I don't know. But you can always write a e2e test and place it next to the other ones (the ones that start a process) |
@rrousselGit Finally figured out a test for this |
See #298 (comment)