-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(app-check): type def fixes #8367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MichaelVerdon - there are e2e tests failing because of the change to return type of getAppCheck() :https://github.com/invertase/react-native-firebase/actions/runs/13769712997/job/38560776497?pr=8367#step:16:14532 You also need to change these the way these are called: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this locally for testing - and even after rebasing against current main, android and iOS appear to work fine for me, so it doesn't seem to have any functional issues. Code looks good on review, so LGTM for merge
Description
https://firebase.google.com/docs/reference/js/app-check.md#gettoken_39fc1b3
closes #8361
Related issues
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter