fix(auth, android): handle native exception in signInWithEmailLink #8502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikehardy
changed the title
mikehardy
force-pushed
the
@mikehardy/sign-in-link-follow-on
branch
from
accf260 to
fbfe6e5
Compare
MichaelVerdon
approved these changes
Apr 30, 2025
the firebase-android-sdk throws an unhandled error if the link is mal-formed (e.g., missing apiKey param) which bubbled up to javascript inappropriately making it very hard to handle now we catch all exceptions and handle correctly with a Promise reject, and we probe the same with an e2e test
mikehardy
force-pushed
the
@mikehardy/sign-in-link-follow-on
branch
from
fbfe6e5 to
530dd79
Compare
|
turns out Other platform also errors if apiKey is missing during sign in - hadn't checked locally since isSignInWithEmailLink doesn't seem to require apiKey. But signInWithEmailLink appears to fail without it. Re-pushed with updated API docs indicating this and e2e test adjusted to handle it |
mikehardy
added
Workflow: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Willham12 pointed out multiple problems with our sign in link handling, and even submitted a PR that handled part of the problem already - this PR handles the remaining two aspects of the problem - a docs update and a native error handling fix
Specifically, the native android signInWithEmailLink method throws an error outside it's Task continuation failure handling, which was unexpected and unhandled in our code. This PR handles that correctly now
Related issues
Release Summary
two conventional commits ready for a rebase and a semantic release
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Subtle to fix, but correctness was enforced because I started it by adding an e2e test and then made our code meet the test expectations
One very subtle thing (for me) is that the new react-native new architecture error handling for bridgeless compatibility mode code is to helpfully package up even unhandled native code exceptions. This changed since the error was logged so I was seeing different behavior in the unhandled exception case - not IllegalArgumentException + crash like expected, but a 'HostError' javascript error object that wasn't from us but was from react-native
Anyway, all handled now
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter