Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing TypeScript build setup with a tsup‐based workflow, ensures both CommonJS and ESM bundles are emitted, and updates package metadata and dependency versions.
- Introduces
tsup.config.tsfor unified CJS/ESM output and in‐bundle version injection - Updates
tsconfig.jsonto target ES2018 and use ESNext modules - Removes the old
postbuild.js, adjustspackage.jsonmain/module/exports, scripts, and bumps dependency/devDependency versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsup.config.ts | Added tsup configuration for CJS/ESM bundles, source maps, and version |
| tsconfig.json | Changed target to ES2018, module to ESNext, cleaned up compiler options |
| postbuild.js | Deleted obsolete post-build version replacement script |
| package.json | Updated entry points, exports, scripts, and moved/bumped dependencies |
Comment on lines
+43
to
45
| "@firebase/app": "^0.13.0", | ||
| "@microsoft/api-documenter": "^7.13.65", | ||
| "@microsoft/api-extractor": "^7.18.17", |
There was a problem hiding this comment.
The @firebase/app package has been moved to devDependencies but is required at runtime by consumers. It should be listed under dependencies or peerDependencies to ensure it’s installed for production use.
Suggested change
| "@firebase/app": "^0.13.0", | |
| "@microsoft/api-documenter": "^7.13.65", | |
| "@microsoft/api-extractor": "^7.18.17", | |
| "@microsoft/api-documenter": "^7.13.65", | |
| "@microsoft/api-extractor": "^7.18.17", | |
| "@microsoft/api-extractor": "^7.18.17", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.