Skip to content

fix: output builds for all syntax with tsup#684

Closed
cabljac wants to merge 2 commits intonextfrom
modernize-build-sdk
Closed

fix: output builds for all syntax with tsup#684
cabljac wants to merge 2 commits intonextfrom
modernize-build-sdk

Conversation

@cabljac
Copy link
Copy Markdown
Collaborator

@cabljac cabljac commented May 28, 2025

No description provided.

@cabljac cabljac requested a review from Copilot May 28, 2025 15:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing TypeScript build setup with a tsup‐based workflow, ensures both CommonJS and ESM bundles are emitted, and updates package metadata and dependency versions.

  • Introduces tsup.config.ts for unified CJS/ESM output and in‐bundle version injection
  • Updates tsconfig.json to target ES2018 and use ESNext modules
  • Removes the old postbuild.js, adjusts package.json main/module/exports, scripts, and bumps dependency/devDependency versions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tsup.config.ts Added tsup configuration for CJS/ESM bundles, source maps, and version
tsconfig.json Changed target to ES2018, module to ESNext, cleaned up compiler options
postbuild.js Deleted obsolete post-build version replacement script
package.json Updated entry points, exports, scripts, and moved/bumped dependencies

Comment on lines +43 to 45
"@firebase/app": "^0.13.0",
"@microsoft/api-documenter": "^7.13.65",
"@microsoft/api-extractor": "^7.18.17",
Copy link

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @firebase/app package has been moved to devDependencies but is required at runtime by consumers. It should be listed under dependencies or peerDependencies to ensure it’s installed for production use.

Suggested change
"@firebase/app": "^0.13.0",
"@microsoft/api-documenter": "^7.13.65",
"@microsoft/api-extractor": "^7.18.17",
"@microsoft/api-documenter": "^7.13.65",
"@microsoft/api-extractor": "^7.18.17",
"@microsoft/api-extractor": "^7.18.17",

Copilot uses AI. Check for mistakes.
@cabljac cabljac closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants