feat(nodes): skip on duplicate loras instead of erroring#6685
feat(nodes): skip on duplicate loras instead of erroring#6685psychedelicious wants to merge 1 commit intomainfrom
Conversation
The `LoRA` and `SDXL LoRA` nodes would error if it duplicated LoRAs. To make the nodes more resilient, they now skip dupes and log a warning to the console instead. Also added a warning for the LoRA Collection Loader nodes. These already skipped but didn't log a warning.
|
Discussed with @StAlKeR7779 - in some cases, skipping duplicates may not be correct - for example, we may want to let the last instance of a LoRA be used, or sum the weights. Maybe we add an enum field - Also, |
|
Of all the possible duplicate handling methods, Maybe we start with |
|
I feel that most cases will be closed by:
For example case with metadata node should be closed by |

Summary
The
LoRAandSDXL LoRAnodes would error if it duplicated LoRAs. To make the nodes more resilient, they now skip dupes and log a warning to the console instead.Also added a warning for the LoRA Collection Loader nodes. These already skipped but didn't log a warning.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1130288930319761428/1266235074647691335
QA Instructions
This workflow has 4 test flows, each with 3 LoRA loaders:
For each flow, set two of the loaders to the same LoRA and the 3rd to a different. The output for each flow should have only two LoRAs, and you should have warnings in the console for each.
If you test this on main, we expect errors for both the chain flows.
lora test(1).json
Merge Plan
n/a
Checklist