Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests by removing uneeded permuations #13

Merged
merged 1 commit into from
Sep 2, 2014

Conversation

nirs
Copy link
Collaborator

@nirs nirs commented Sep 1, 2014

Test simple was 20 times, each run with 1..20 iterations of the
reconnecting code. This consumed about half of the test time for no
value.

Now we run only one time, using 20 iterations.

Test simple was 20 times, each run with 1..20 iterations of the
reconnecting code. This consumed about half of the test time for no
value.

Now we run only one time, using 20 iterations.
@ionelmc
Copy link
Owner

ionelmc commented Sep 1, 2014

When I did it, it was effectively a poor man's stress test. It even catch some bugs: https://travis-ci.org/ionelmc/python-manhole/jobs/10214295#L237

We should still have something (slow, annoying and inefficient) like this, at least for the stress suite from #14

@nirs
Copy link
Collaborator Author

nirs commented Sep 2, 2014

Well the current test is still slow and annoying, taking about 4 seconds to make 20 re-connections. Do you like to have more then 20 iterations?

For long term, the regular tests should check one reconnect, and the stress tests should be configurable, so you can run it for minutes or hours as needed.

@ionelmc ionelmc merged commit a3b9e84 into ionelmc:master Sep 2, 2014
@ionelmc
Copy link
Owner

ionelmc commented Sep 2, 2014

Fine, lets continue in #14

@nirs nirs deleted the faster-tests branch September 27, 2014 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants