Fix leftover /tmp/manhole-pid sockets in the tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manhole.install() registers an exit function removing the manhole socket, but atexit function do not run when process is terminated by an unhandled signal. In the fork tests, we avoid this issue by terminating child processes with SIGINT, however the test child processes, created by the process_tests library, are terminate using SIGTERM in TestProcess.__exit__. Adding SIGTERM signal handler fixed this issue. We probably need to document this as a workaround for issue ionelmc#8
|
Ah damn, how did I miss this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manhole.install() registers an exit function removing the manhole
socket, but atexit function do not run when process is terminated by an
unhandled signal.
In the fork tests, we avoid this issue by terminating child processes
with SIGINT, however the test child processes, created by the
process_tests library, are terminate using SIGTERM in
TestProcess.__exit__.Adding SIGTERM signal handler fixed this issue.
We probably need to document this as a workaround for issue #8