Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify .prettierignore settings #123

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jonz94
Copy link
Contributor

@jonz94 jonz94 commented Dec 26, 2024

As of Prettier v3, files ignored by .gitignore are also ignored by default. This allow us to remove redundant settings from .prettierignore.

Ref: https://prettier.io/blog/2023/07/05/3.0.0#cli

Screenshot 2024-12-26 at 2 28 51 PM

As of Prettier v3, files ignored by `.gitignore` are also ignored by
default. This allow us to remove redundant settings from `.prettierignore`.

Ref: https://prettier.io/blog/2023/07/05/3.0.0#cli
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Can you remove the root .prettierignore? There is no point in having an empty file.

@jonz94
Copy link
Contributor Author

jonz94 commented Jan 15, 2025

I just double-checked. This PR already removes the root .prettierignore file. 👍

@jonz94 jonz94 requested a review from jcesarmobile January 15, 2025 15:35
@jcesarmobile
Copy link
Member

oh, you are right, sorry about that

@jcesarmobile jcesarmobile merged commit 8788963 into ionic-team:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants