Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chip): add hue property for the ionic theme #30308

Merged
merged 38 commits into from
Apr 11, 2025
Merged

feat(chip): add hue property for the ionic theme #30308

merged 38 commits into from
Apr 11, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 26, 2025 •
edited
Loading

Issue number: internal

What is the current behavior?

The chip component does not support the hue property.

What is the new behavior?

Adds support for the bold and subtle hue for the chip. Defaults to subtle.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel Vercel
Copy link

vercel bot commented Mar 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 5:13pm

@github-actions github-actions bot added the package: core @ionic/core package label Mar 26, 2025
@brandyscarney brandyscarney changed the base branch from main to FW-6252 March 26, 2025 15:55
@brandyscarney brandyscarney changed the title feat(chip): add subtle hue for the ionic theme feat(chip): add bold hue for the ionic theme Apr 2, 2025
@brandyscarney brandyscarney changed the title feat(chip): add bold hue for the ionic theme feat(chip): add hue support for the ionic theme Apr 2, 2025
@brandyscarney brandyscarney changed the title feat(chip): add hue support for the ionic theme feat(chip): add hue property for the ionic theme Apr 2, 2025
@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Apr 3, 2025
@brandyscarney brandyscarney marked this pull request as ready for review April 7, 2025 19:43
@brandyscarney brandyscarney requested a review from a team as a code owner April 7, 2025 19:43
@brandyscarney brandyscarney requested review from gnbm and removed request for a team April 7, 2025 19:43
thetaPC
thetaPC approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comments aren't blockers

core/src/components/chip/chip.ionic.scss Outdated
}

:host(.chip-outline.chip-bold) {
// TODO this is a made up design choice based on a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a ticket associated to this TODO?

@brandyscarney brandyscarney changed the base branch from FW-6252 to next April 11, 2025 16:28
@brandyscarney brandyscarney merged commit b31e0ef into next Apr 11, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6252-chip branch April 11, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandyscarney @thetaPC @BenOsodrac @Ionitron