Visual warts #25
Closed
Visual warts #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russok
commented
Aug 9, 2019
•
russok
commented
- added 100% height to the wrapper DIV to avoid truncation of content (same as issue Wrong height property on about/login pages in demo app #12)
- isAuthenticated is used as if it means the opposite (same as issue Inverted menu items #24)
- Tutorial menu item is disabled for no reason: added the route to tutorial
- The label "Enter your support message below" is truncated: reads as "Enter your support me..."
russok
commented
Aug 9, 2019
| </IonList> | ||
| <IonList> | ||
| <IonListHeader>Tutorial</IonListHeader> | ||
| <IonItem onClick={() => {}}> |
There was a problem hiding this comment.
the handler like that disables the item
russok
commented
Aug 9, 2019
| function renderlistItems(list: any[]) { | ||
| return list | ||
| .filter(route => !!route.path) |
There was a problem hiding this comment.
all paths are truthy, no need for filtering
|
Thanks for the PR and sorry for the long delay in reviewing this! The project has since gone through several major updates, and these issues should now be resolved. You can check out the latest version here: https://ionic-react-conference-app-ionic1.vercel.app/tutorial If you're still seeing any problems, feel free to open a new issue. We appreciate your contribution! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.