-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow vmtemplate selection based on tags #343
Conversation
🚀 e2e tests runWe add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
ℹ️ Ask a |
Hm indeed that's not how I'd expect selection by tag to work, either. I shouldn't need to pass the exact tags, just enough tags to get a result. |
what about multiple VMs has the same matchTags |
You need to pass enough tags to get a unique result. I agree with you though that you shouldn't need to pass all the tags a template has. |
External PRTest runs on external PRs require manual approval. |
We had a chat about this and decided to keep this behaviour and document it. |
External PRTest runs on external PRs require manual approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the lint and you are good to go.
External PRTest runs on external PRs require manual approval. |
External PRTest runs on external PRs require manual approval. Note: This PR changes the following non-go, non-docs files: |
|
(sourceNode + templateID)
andtemplateSelector
are supposed to be mutually exclusivesourceNode
+templateID
Issue #, if available:
#338
Description of changes:
Allows selecting the vm template via
on
ProxmoxMachineTemplate
objects.Testing performed: