🌱 Refactoring: move NetworkConfigData out of cloudinit pkg #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbenjemaa
requested review from
65278,
avorima,
pborn-ionos and
wikkyk
as code owners
🚀 e2e tests runWe add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
ℹ️ Ask a |
mcbenjemaa
changed the title
mcbenjemaa
force-pushed
the
net-config
branch
from
fcb2f33 to
cc5584e
Compare
wikkyk
previously approved these changes
Jan 20, 2025
wikkyk
reviewed
Jan 20, 2025
wikkyk
approved these changes
Jan 20, 2025
|
e2e succeeded before my trivial change to comment so another run not necessary. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the struct
NetworkConfigDataout of the cloudinit pkg,Since ignition also uses the struct to generate network configuration,
NetworkConfigDatabecomes a common type and can be moved to a standard package.Closes #341