Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor share and nic data sources. fix sleep on share resource #715

Merged
merged 10 commits into from
Nov 25, 2024
Merged

fix: refactor share and nic data sources. fix sleep on share resource #715

merged 10 commits into from
Nov 25, 2024

Conversation

cristiGuranIonos
Copy link
Collaborator

What does this fix or implement?

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

Base automatically changed from fix/ds_computed_id_name to master November 22, 2024 08:36
@cristiGuranIonos cristiGuranIonos changed the title fix: refactor share and nic data sources fix: refactor share and nic data sources. fix sleep on share resource Nov 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cristiGuranIonos cristiGuranIonos merged commit ff87e88 into master Nov 25, 2024
7 checks passed
@cristiGuranIonos cristiGuranIonos deleted the fix/rewrite_ds branch November 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimihalescu mimihalescu mimihalescu approved these changes

@rmocanu-ionos rmocanu-ionos Awaiting requested review from rmocanu-ionos rmocanu-ionos was automatically assigned from ionos-cloud/sdks-development

@avirtopeanu-ionos avirtopeanu-ionos Awaiting requested review from avirtopeanu-ionos avirtopeanu-ionos was automatically assigned from ionos-cloud/sdks-development

@adeatcu-ionos adeatcu-ionos Awaiting requested review from adeatcu-ionos adeatcu-ionos was automatically assigned from ionos-cloud/sdks-development

@glimberea glimberea Awaiting requested review from glimberea glimberea was automatically assigned from ionos-cloud/sdks-development

@cbeti-ionos cbeti-ionos Awaiting requested review from cbeti-ionos cbeti-ionos was automatically assigned from ionos-cloud/sdks-development

@digna-ionos digna-ionos Awaiting requested review from digna-ionos digna-ionos was automatically assigned from ionos-cloud/sdks-development

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristiGuranIonos @mimihalescu