Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use bundle instead of sdk-go-container-registry #752

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: Use bundle instead of sdk-go-container-registry #752

wants to merge 3 commits into from

Conversation

adeatcu-ionos
Copy link
Contributor

What does this fix or implement?

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

rmocanu-ionos
rmocanu-ionos reviewed Jan 28, 2025
View reviewed changes
go.mod
@@ -17,6 +17,7 @@ require (
github.com/iancoleman/strcase v0.3.0
github.com/ionos-cloud/sdk-go-api-gateway v1.0.0
github.com/ionos-cloud/sdk-go-bundle/products/cdn/v2 v2.1.0
github.com/ionos-cloud/sdk-go-bundle/products/containerregistry/v2 v2.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to remove the old entry
github.com/ionos-cloud/sdk-go-container-registry v1.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmocanu-ionos done in 4210c7f

@adeatcu-ionos adeatcu-ionos force-pushed the use-bundle-instead-of-sdk-for-container-registry branch from f156c45 to c9b6927 Compare January 28, 2025 15:07
@adeatcu-ionos
Copy link
Contributor Author

adeatcu-ionos commented Jan 28, 2025 •
edited
Loading

INFO:

I ran TestAccContainerRegistryTokenBasic and the step 8/8 fails but I think this has nothing to do with the changes in this PR. Fixing the test is out of scope of this PR and will be fixed in another one. All other tests were passing.

L.E:

After some linter changes, I tried to run the tests again but it takes way more time to run them, so I stopped the process, I will run the tests again and, if needed, I will speak with the API team.

@adeatcu-ionos adeatcu-ionos force-pushed the use-bundle-instead-of-sdk-for-container-registry branch from 12826e1 to 08b9794 Compare January 28, 2025 16:12
rmocanu-ionos
rmocanu-ionos previously approved these changes Jan 29, 2025
View reviewed changes
@adeatcu-ionos adeatcu-ionos force-pushed the use-bundle-instead-of-sdk-for-container-registry branch from 08b9794 to da4bcd6 Compare January 29, 2025 12:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmocanu-ionos rmocanu-ionos rmocanu-ionos left review comments

@avirtopeanu-ionos avirtopeanu-ionos avirtopeanu-ionos left review comments

@mimihalescu mimihalescu Awaiting requested review from mimihalescu mimihalescu was automatically assigned from ionos-cloud/sdks-development

@cristiGuranIonos cristiGuranIonos Awaiting requested review from cristiGuranIonos cristiGuranIonos was automatically assigned from ionos-cloud/sdks-development

@glimberea glimberea Awaiting requested review from glimberea glimberea was automatically assigned from ionos-cloud/sdks-development

@cbeti-ionos cbeti-ionos Awaiting requested review from cbeti-ionos cbeti-ionos was automatically assigned from ionos-cloud/sdks-development

@cciopa-ionos cciopa-ionos Awaiting requested review from cciopa-ionos cciopa-ionos was automatically assigned from ionos-cloud/sdks-development

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adeatcu-ionos @rmocanu-ionos @avirtopeanu-ionos