chore: Update electron and related dependencies #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rajivshah3
reviewed
Nov 2, 2023
| "electron-builder": "^24.0.0", | ||
| "electron-notarize": "^1.0.0", | ||
| "electron": "27.0.2", | ||
| "electron-builder": "^24.6.4", |
There was a problem hiding this comment.
I'm not sure if this was in previous versions of electron-builder, but we may need to adjust our electron-builder-config.js so that we don't notarize the app twice (it's unclear what the default behavior of the notarize option is — it seems to wrap around @electron/notarize)
There was a problem hiding this comment.
We weren't signing twice. Anyway, I have now changed a bit the config, electron-builder will now sign for us instead of us manually calling @electron/notarize
There was a problem hiding this comment.
@begonaalvarezd fyi
This was referenced Dec 20, 2023
marc2332
force-pushed
the
chore/update-electron
branch
from
85e1630 to
c1b7510
Compare
marc2332
force-pushed
the
chore/update-electron
branch
from
c1b7510 to
632ee34
Compare
begonaalvarezd
changed the base branch from
develop
to
release/desktop-shimmer-2.1.11
begonaalvarezd
approved these changes
Feb 1, 2024
begonaalvarezd
merged commit 0dcbb20
into
release/desktop-shimmer-2.1.11
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7655