Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow l2 withdrawal (funds stuck in l2 that didnt reach evm) #7734

Merged
merged 17 commits into from
Feb 1, 2024
Merged

feat: allow l2 withdrawal (funds stuck in l2 that didnt reach evm) #7734

merged 17 commits into from
Feb 1, 2024

Conversation

marc2332
Copy link
Collaborator

Closes #7695

@brancoder brancoder marked this pull request as ready for review December 12, 2023 15:03
cpl121
cpl121 requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying the PR, but I think it's not working correctly. I create a stuck tx, and then i try to withdraw L2 funds, but I have a Not enough balance. error and the Withdraw from L2 popup stays in an infinite loop

@brancoder
Copy link
Collaborator

I'm trying the PR, but I think it's not working correctly. I create a stuck tx, and then i try to withdraw L2 funds, but I have a Not enough balance. error and the Withdraw from L2 popup stays in an infinite loop

What is the amount that you tried to withdraw?

@brancoder brancoder requested a review from cpl121 January 19, 2024 09:33
@brancoder brancoder requested a review from cpl121 January 22, 2024 14:22
cpl121
cpl121 requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
It works correctly with the software profiles, but I have found a problem with ledger

packages/desktop/components/popups/WithdrawFromL2Popup.svelte Outdated Show resolved Hide resolved
@brancoder brancoder requested a review from cpl121 January 25, 2024 14:16
cpl121
cpl121 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly for both profiles (ledger and software) 🚀
Amazing job @brancoder 👏🏼

@begonaalvarezd begonaalvarezd changed the base branch from develop to release/desktop-shimmer-2.1.11 February 1, 2024 12:21
@begonaalvarezd begonaalvarezd changed the title feat: 1.5 layer withdrawal feat: allow l2 withdrawal (funds stuck in l2 that didnt reach evm) Feb 1, 2024
begonaalvarezd
begonaalvarezd approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@begonaalvarezd begonaalvarezd merged commit 9c944b5 into release/desktop-shimmer-2.1.11 Feb 1, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/l1-5-withdrawal branch February 1, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees

@brancoder brancoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add feature to withdraw base tokens stuck funds in layer 1.5
4 participants
@marc2332 @brancoder @begonaalvarezd @cpl121