Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add "discover addresses" using a permanode #7750

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Feat: Add "discover addresses" using a permanode #7750

merged 12 commits into from
Dec 18, 2023

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Nov 29, 2023 •
edited
Loading

Summary

  • Generate addresses not known by the sdk or locally and query the address against a permanode to know if it had history
  • Persist all known addresses in localStorage to save requests in the future
  • Use gap logic in the search algorithm to know when to stop generating addresses

Resolves #7594

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Network: Testnet

@brancoder brancoder self-requested a review December 6, 2023 12:37
brancoder
brancoder requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix type check and lint errors

packages/desktop/components/popups/AddressHistoryPopup.svelte Outdated Show resolved Hide resolved
@msarcev
Copy link
Collaborator Author

msarcev commented Dec 11, 2023

I had to modify checkAndMigrateChrysalisProfiles here for the new field in IPersistedAccountData. Please confirm that this is fine. :D

begonaalvarezd
begonaalvarezd approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 works

@brancoder brancoder mentioned this pull request Dec 13, 2023
Merged
10 tasks
brancoder
brancoder approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@begonaalvarezd begonaalvarezd merged commit 6ee934c into develop Dec 18, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/discover-addresses branch December 18, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@brancoder brancoder brancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add "View address history" to IOTA app: Add "discover addresses" using a permanode
3 participants
@msarcev @begonaalvarezd @brancoder