Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove ProfileManager remaining code #7809

Merged
merged 38 commits into from
Jan 23, 2024
Merged

refactor: Remove ProfileManager remaining code #7809

merged 38 commits into from
Jan 23, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Dec 22, 2023 •
edited
Loading

Closes #7808
Depends on #7804
Requires iotaledger/iota-sdk#1830

@begonaalvarezd begonaalvarezd linked an issue Dec 24, 2023 that may be closed by this pull request
[Task] Remove ProfileManager remaining code #7808
Closed
@marc2332
Copy link
Collaborator Author

marc2332 commented Jan 15, 2024 •
edited
Loading

This is in a decent state IMO, we can refactor/cleanup/whatever what is left as we complete other tasks

@marc2332 marc2332 marked this pull request as ready for review January 15, 2024 17:32
Base automatically changed from refactor/dynamic-password to develop-iota2.0 January 16, 2024 12:35
@marc2332 marc2332 marked this pull request as draft January 17, 2024 08:51
@marc2332 marc2332 marked this pull request as ready for review January 17, 2024 11:58
This was referenced Jan 17, 2024
Merged
Merged
cpl121
cpl121 requested changes Jan 18, 2024
View reviewed changes
packages/desktop/components/AccountActivity.svelte Show resolved Hide resolved
packages/desktop/components/buttons/popup-buttons/MintNativeTokenButton.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/settings/views/advanced/HiddenAccounts.svelte Show resolved Hide resolved
packages/shared/lib/contexts/onboarding/actions/createShimmerClaimingProfileManager.ts Show resolved Hide resolved
packages/shared/lib/contexts/onboarding/actions/destroyShimmerClaimingWallet.ts Show resolved Hide resolved
packages/shared/lib/core/wallet/actions/buildWalletState.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/actions/index.ts Show resolved Hide resolved
packages/shared/lib/core/wallet/interfaces/wallet-state.interface.ts Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/outputs/preprocessGroupedOutputs.ts Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/outputs/preprocessOutgoingTransaction.ts Show resolved Hide resolved
@marc2332 marc2332 requested a review from cpl121 January 19, 2024 08:13
evavirseda
evavirseda approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very clean 🧹 🧹

cpl121
cpl121 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

begonaalvarezd
begonaalvarezd requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking amazing 🚀 just couple minor comments added

packages/shared/lib/contexts/governance/utils/getParticipationsForProposal.ts Outdated Show resolved Hide resolved
packages/shared/lib/contexts/governance/utils/isVotingForProposal.ts Outdated Show resolved Hide resolved
packages/shared/lib/contexts/governance/utils/isVotingForSelectedProposal.ts Show resolved Hide resolved
packages/shared/lib/core/profile/constants/login-steps.constant.ts Show resolved Hide resolved
packages/shared/lib/core/profile/interfaces/chrysalis-persisted-profile.interface.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/profile/stores/index.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/secret-manager/stores/secret-manager.store.ts Show resolved Hide resolved
@cpl121 cpl121 requested a review from begonaalvarezd January 23, 2024 13:26
begonaalvarezd
begonaalvarezd requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responded some comments

@cpl121 cpl121 requested a review from begonaalvarezd January 23, 2024 16:13
@begonaalvarezd begonaalvarezd merged commit 2c44c89 into develop-iota2.0 Jan 23, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/remove-profile-manager branch January 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Remove ProfileManager remaining code
4 participants
@marc2332 @begonaalvarezd @evavirseda @cpl121