feat: hook logic in implicit account creation step 1 #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-account-creation-view
…are-ui-step1 packages/desktop/views/account/multi-step/ShowOneTimeAddress.svelte packages/desktop/views/implicit-account-creation/views/activate/MainView.svelte
…t-account-creation-view
…t-account-creation-view packages/desktop/views/implicit-account-creation/ImplicitAccountCreationRouterView.svelte
…t-account-creation-view
begonaalvarezd
requested changes
Jan 10, 2024
|
|
||
| try { | ||
| balances = await wallet.getBalance() | ||
| depositAddress = await getDepositAddress(wallet) |
There was a problem hiding this comment.
🔈 @cpl121
packages/shared/lib/core/wallet/utils/getDepositAddress.ts
Note for the future: the implementation of getDepositAddress is incorrect, the deposit address should be the address of the selected block issuer account output , not the ed25519 address
|
|
||
| // TODO: Replace with proper address | ||
| const DUMMY_ADDRESS = 'iota1q9f0mlq8yxpx2nck8a0slxnzr4ef2ek8f5gqxlzd0wasgp73utryjtzcp98' | ||
| $: depositAddress = $selectedWallet?.depositAddress |
There was a problem hiding this comment.
the one time deposit address is not the deposit address but the implicit account address
…are-ui-step1 packages/desktop/views/dashboard/wallet/views/WalletImplicitAccountView.svelte packages/desktop/views/dashboard/wallet/views/multi-step/MultiStep.svelte
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
…logic-step1 packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
evavirseda
requested review from
begonaalvarezd and
cpl121
and removed request for
cpl121
cpl121
requested changes
Jan 14, 2024
...p/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
Outdated
Show resolved
Hide resolved
...p/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
Outdated
Show resolved
Hide resolved
…step1 packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
marc2332
approved these changes
Jan 17, 2024
begonaalvarezd
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist