This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Feat: Add validator tip set #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events to start tracking of validators in TipManager
piotrm50
approved these changes
Jan 22, 2024
| return | ||
| } | ||
|
|
||
| committee, exists := t.retrieveCommitteeInSlot(tipMetadata.Block().ID().Slot()) |
There was a problem hiding this comment.
This is a hot path that reads data from the committee KVStore for each block - we should add a cache at some level. Maybe we should have a committee cache in SeatManager and clear it whenever SybilProtection.Reset() is called? Not necessarily as part of this PR, but then we should create an issue for that.
piotrm50
force-pushed
the
feat/validator-tipset
branch
from
7444597 to
cddc16f
Compare
This was referenced Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.