This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Add optional check when starting engine about correctness of last commitment and ledger state #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 5, 2024
piotrm50
suggested changes
Mar 7, 2024
piotrm50
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to cover two issues: #707 and #708
Upon starting an engine, and loading data into storage, it optionally triggers the check of the commitment and the ledger state. Once triggered, it then verifies the ledger state against the commitment and recomputes the latest commitment to ensure that the commitment fields correspond to the commitment ID.
It requires accessing the roots of the latest commitment, so when creating a snapshot for a certain slot, we additionally store all the roots of the respective commitment (unless the genesis slot). When loading a snapshot, we additionally import the roots (unless the genesis slot).
One suite test is included to check the correctness of the whole logic.