feat(dapp): improve gas management on transactions#1077
Open
feat(dapp): improve gas management on transactions#1077
Conversation
KeitoTadashi
approved these changes
Jan 16, 2026
| @@ -232,6 +232,7 @@ export function RenewNameDialog({ setOpen, name, onRenew }: RenewDialogProps) { | |||
| const disableEdit = isSendingTransaction || isSigning || renewOptions.length === 0; | |||
| const disableSave = isLoading || !canRenew || !renewYears || !updateNameTransaction; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| const disableSave = isLoading || !canRenew || !renewYears || !updateNameTransaction; | |
| const disableSave = isLoading || !canRenew || !renewYears || txError; |
KeitoTadashi
requested changes
Jan 16, 2026
Contributor
KeitoTadashi
left a comment
KeitoTadashi
left a comment
There was a problem hiding this comment.
disable button here, I was able to hit renew and approve the TX, then renew succesfully pop, but TX failed
Grabacion.de.pantalla.desde.2026-01-16.15-05-30.mp4
Contributor
|
This pull request has been deployed to Vercel.
|
KeitoTadashi
previously approved these changes
Feb 9, 2026
brancoder
requested changes
Feb 11, 2026
Contributor
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
requested a change until we decide how to display the price
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When buying a name that costs 50 IOTA and you only have 50 IOTA you will get an error that you cannot pay for the transaction but the cost remains 50 IOTA, which is unclear because we should include the gas price even if the user cannot pay for it