feat(dapp): add tradeport link to name options#1192
Conversation
|
This pull request has been deployed to Vercel.
|
KeitoTadashi
left a comment
KeitoTadashi
left a comment
There was a problem hiding this comment.
it looks good, left few comments
| isDisabled: !namePermissions.allowChildCreation, | ||
| }, | ||
| { | ||
| isHidden: !nft.isRenewable || nft.isSubname, |
There was a problem hiding this comment.
please align this file with the new property isRenewable, we have nft.isRenewable and isNameGracePeriodExpired
There was a problem hiding this comment.
actually we should do it like:
isHidden: nft.isExpired || nft.isSubname
otherwise expired names in grace period could be listed
dapp/package.json
Outdated
| "@iota/apps-ui-icons": "0.0.0-experimental-20260325094734", | ||
| "@iota/apps-ui-kit": "0.0.0-experimental-20260325094734", |
There was a problem hiding this comment.
we should probably wait until we can bump to a proper version, we shouldnt release with this experimental release
| } | ||
| } | ||
|
|
||
| export class HowToListNameClicked implements BaseEvent { |
There was a problem hiding this comment.
We dont need this, we have autocapture clicks enabled in amplitude for this project so this click should be already tracked by default.
Please revert everything related to amplitude 🙏🏼
4 participants
Close #1191