feat: add AuthContext to the implicit aliases list
#8922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
iota-ci
added
sc-platform
valeriyr
force-pushed
the
vm-lang/aa-auth/8907-implicit-alias-auth-context
branch
from
0532ca0 to
2510bb2
Compare
Base automatically changed from
vm-lang/aa-auth/8845-auth-context-improvements
to
vm-lang/aa-auth/8116-feature-branch
October 16, 2025 15:14
valeriyr
force-pushed
the
vm-lang/aa-auth/8907-implicit-alias-auth-context
branch
from
2510bb2 to
f618ca4
Compare
TheMrAI
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
From a technical perspective all looks good.
But I am not sure this change is necessary at this time. Or at all.
AuthContext is not nearly as fundamental as TxContext, transfer or object (the other implicit members) as to warrant this inclusion. Maybe in the future, but at this point this looks very premature.
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/object.move
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[run-ci]
Description of change
The
auth_contextmodule and theAuthContextstruct are added to the implicit aliases list.Links to any relevant issues
fixes #8907