blockservice: make ContextWithSession shortcut grabSessionFromContext inside newSession #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inside newSession This was not wrong however it was confusing, grabSessionFromContext would show up twice in logs.
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 65.58% 65.60% +0.01%
==========================================
Files 207 207
Lines 25617 25619 +2
==========================================
+ Hits 16801 16807 +6
+ Misses 7342 7339 -3
+ Partials 1474 1473 -1
|
hacdias
approved these changes
Jan 12, 2024
Jorropo
deleted the
01-12-blockservice_make_ContextWithSession_shortcut_grabSessionFromContext_inside_newSession
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.