Skip to content

fix: update dependencies #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: update dependencies #100

wants to merge 1 commit into from

Conversation

zebateira
Copy link
Contributor

@zebateira zebateira commented Apr 2, 2021

This PR updates the project dependecies.

Unused packages removed:

Example:

Beast of Bodmin
A large feline inhabiting Bodmin Moor.

I thought it would be ok to remove all of these since we have not used them so far. But let me know what you think @jessicaschilling, particularly the markdown plugins.

Package missing

Also added autoprefixer since we are requiring it directly but we don't have it in our package.json. I understand it is a direct dependency of stylelint, tailwaind and vuepress, but it doesn't hurt to have it there.

Partially addresses: #34

@zebateira zebateira mentioned this pull request Apr 2, 2021
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Apr 2, 2021

Thanks @zebateira - I'd suggest removing these on the basis that we can always add them back if someone needs them.

@cwaring
Copy link
Member

cwaring commented Apr 2, 2021

the markdown plugins are not really a burden on build time and we should consider keeping those and encourage their use through guides (also standard across the docs atm). Especially embedded videos in posts because adding iframe snippets directly ends up really messy when it comes to styling.

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Apr 2, 2021

Please disregard my previous comment; whatever @cwaring says is final directive.

@cwaring
Copy link
Member

cwaring commented Apr 2, 2021

@vuepress/plugin-last-updated could potentially shave off many seconds from the build time on a big site if we can get away with not using it. This has to spawn a child process to check the file modified info on disk which can be slow with many pages. I'd nudge you to experiment with this first :)

@zebateira
Copy link
Contributor Author

The last updated plugin is used for SEO here: https://github.com/ipfs/ipfs-blog/blob/main/src/.vuepress/config.js#L239
So I think we need to keep it.
I'll cancel this PR since there are no gains from it.

@zebateira zebateira closed this Apr 8, 2021
@zebateira zebateira deleted the fix/dependencies-update branch April 8, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants