feat: cache and verify downloaded archive #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves us time on CI and gives more confidence that downloaded archive is valid:
node-fetch
withgot
)electron
,electron-builder
and even our ownaegir
already do this type of caching for big third-party downloadsgo-ipfs-dep
(Deprecate in favor of npm-go-ipfs ipfs-inactive/npm-go-ipfs-dep#45).sha512
manifest and compares it with sha512 of downloaded archiveDemo: caching and verifying in action
First time downloads archive to the cache:
Second time reused archive from the cache:
Note that SHA512 is compared on every run.
If a single bit was flipped, it will return an error:
cc @andrew