Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for null coalesce assign operator #94

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add support for null coalesce assign operator #94

merged 1 commit into from
Jan 13, 2025

Conversation

thegallagher
Copy link
Contributor

No description provided.

nikic
nikic reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, because it doesn't model the short-circuiting behavior. But the existing ?? handling doesn't do so either, so I guess this is fine as a starting point.

@nikic nikic merged commit f85725f into ircmaxell:master Jan 13, 2025
6 checks passed
@thegallagher
Copy link
Contributor Author

Thanks for the feedback. I assume the correct behaviour would be to expand null coalesce to JumpIf, as with LogicalAnd and LogicalOr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegallagher @nikic