Update JaySandesara.yml #2529
Closed
Update JaySandesara.yml #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@JaySandesara You ended up closing this PR. Maybe you tried to rebase it? (If you make a PR from the default branch on your fork then if you rebase to bring in upstream issues at a point GitHub detects no changes and then closes it — always best to never use the default branch and make your PR specific dev branch). |
Contributor
Author
|
No I closed it because the CI was failing. I made a new PR here: #2530 - but this also seems to fail |
Member
|
Okay. You don't need to close PRs if the CI fails. You can revise them in place and put them in draft mode if they're not ready for review yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding presentations for annual review