Skip to content

Merge pull request #4 from iron-fish/upgrade-bip0039 #14

Merge pull request #4 from iron-fish/upgrade-bip0039

Merge pull request #4 from iron-fish/upgrade-bip0039 #14

Triggered via push October 16, 2024 23:07
Status Failure
Total duration 5m 20s
Artifacts

ci.yml

on: push
Matrix: build
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

27 errors and 62 warnings
mismatched types: zcash_primitives/src/sapling/prover.rs#L110
error[E0308]: mismatched types --> zcash_primitives/src/sapling/prover.rs:110:73 | 110 | PublicKey(proof_generation_key.ak.into()).randomize(ar, SPENDING_KEY_GENERATOR); | --------- ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR` | | | arguments to this method are incorrect | note: method defined here --> zcash_primitives/src/sapling/redjubjub.rs:105:12 | 105 | pub fn randomize(&self, alpha: jubjub::Fr, p_g: SubgroupPoint) -> Self { | ^^^^^^^^^ ------------------ help: consider dereferencing the type | 110 | PublicKey(proof_generation_key.ak.into()).randomize(ar, *SPENDING_KEY_GENERATOR); | +
mismatched types: zcash_primitives/src/transaction/components/sapling.rs#L530
error[E0308]: mismatched types --> zcash_primitives/src/transaction/components/sapling.rs:530:102 | 530 | ...rized { binding_sig: bsk.sign(&fake_bvk_bytes, &mut rng, VALUE_COMMITMENT_RANDOMNESS_GENERATOR) }, | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `VALUE_COMMITMENT_RANDOMNESS_GENERATOR` | | | arguments to this method are incorrect | note: method defined here --> zcash_primitives/src/sapling/redjubjub.rs:74:12 | 74 | pub fn sign<R: RngCore>(&self, msg: &[u8], rng: &mut R, p_g: SubgroupPoint) -> Signature { | ^^^^ ------------------ help: consider dereferencing the type | 530 | authorization: Authorized { binding_sig: bsk.sign(&fake_bvk_bytes, &mut rng, *VALUE_COMMITMENT_RANDOMNESS_GENERATOR) }, | +
no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope: zcash_primitives/src/transaction/components/sapling.rs#L491
error[E0599]: no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope --> zcash_primitives/src/transaction/components/sapling.rs:491:47 | 491 | .prop_map(|v| blstrs::Scalar::from_bytes_wide(&v)), | ^^^^^^^^^^^^^^^ function or associated item not found in `jubjub::Fq` | help: there is an associated function `from_bytes_be` with a similar name | 491 | .prop_map(|v| blstrs::Scalar::from_bytes_be(&v)), | ~~~~~~~~~~~~~
mismatched types: zcash_primitives/src/transaction/components/sapling.rs#L479
error[E0308]: mismatched types --> zcash_primitives/src/transaction/components/sapling.rs:479:73 | 479 | spend_auth_sig: sk1.sign(&fake_sighash_bytes, &mut rng, SPENDING_KEY_GENERATOR), | ---- ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR` | | | arguments to this method are incorrect | note: method defined here --> zcash_primitives/src/sapling/redjubjub.rs:74:12 | 74 | pub fn sign<R: RngCore>(&self, msg: &[u8], rng: &mut R, p_g: SubgroupPoint) -> Signature { | ^^^^ ------------------ help: consider dereferencing the type | 479 | spend_auth_sig: sk1.sign(&fake_sighash_bytes, &mut rng, *SPENDING_KEY_GENERATOR), | +
the size for values of type `[u8]` cannot be known at compilation time: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.5.0/src/sugar.rs#L637
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time --> zcash_primitives/src/transaction/components/sapling.rs:455:5 | 455 | / prop_compose! { 456 | | /// produce a spend description with invalid data (useful only for serialization 457 | | /// roundtrip testing). 458 | | fn arb_spend_description()( ... | 481 | | } 482 | | } | |_____^ doesn't have a size known at compile-time | = help: within `(jubjub::ExtendedPoint, jubjub::Fq, sapling::Nullifier, _, [u8; 32], [u8])`, the trait `std::marker::Sized` is not implemented for `[u8]`, which is required by `(_, _, _, _, _, _): std::marker::Sized` = note: required because it appears within the type `(jubjub::ExtendedPoint, jubjub::Fq, sapling::Nullifier, _, [u8; 32], [u8])` = note: all function arguments must have a statically known size = note: this error originates in the macro `prop_compose` (in Nightly builds, run with -Z macro-backtrace for more info)
the size for values of type `[u8]` cannot be known at compilation time: zcash_primitives/src/transaction/components/sapling.rs#L468
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time --> zcash_primitives/src/transaction/components/sapling.rs:468:13 | 468 | fake_sighash_bytes in prop::array::uniform32(prop::num::u8::ANY), | ^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `[u8]` = note: all local variables must have a statically known size = help: unsized locals are gated as an unstable feature
mismatched types: zcash_primitives/src/transaction/components/sapling.rs#L472
error[E0308]: mismatched types --> zcash_primitives/src/transaction/components/sapling.rs:472:52 | 472 | let rk = PublicKey::from_private(&sk1, SPENDING_KEY_GENERATOR); | ----------------------- ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR` | | | arguments to this function are incorrect | note: associated function defined here --> zcash_primitives/src/sapling/redjubjub.rs:100:12 | 100 | pub fn from_private(privkey: &PrivateKey, p_g: SubgroupPoint) -> Self { | ^^^^^^^^^^^^ ------------------ help: consider dereferencing the type | 472 | let rk = PublicKey::from_private(&sk1, *SPENDING_KEY_GENERATOR); | +
no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope: zcash_primitives/src/transaction/components/sapling.rs#L462
error[E0599]: no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope --> zcash_primitives/src/transaction/components/sapling.rs:462:47 | 462 | .prop_map(|v| blstrs::Scalar::from_bytes_wide(&v)), | ^^^^^^^^^^^^^^^ function or associated item not found in `jubjub::Fq` | help: there is an associated function `from_bytes_be` with a similar name | 462 | .prop_map(|v| blstrs::Scalar::from_bytes_be(&v)), | ~~~~~~~~~~~~~
Clippy (beta)
Clippy had exited with the 101 exit code
Intra-doc links
failed to select a version for the requirement `ahash = "^0.7"`
Intra-doc links
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Bitrot check
failed to select a version for the requirement `ahash = "^0.7"`
Bitrot check
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Rustfmt
failed to select a version for the requirement `ahash = "^0.7"`
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on ubuntu-latest
Input required and not supplied: path
Clippy (1.56.1)
Clippy had exited with the 101 exit code
Test on macOS-latest
The job was canceled because "ubuntu-latest" failed.
Test on macOS-latest
The operation was canceled.
Test on windows-latest
The job was canceled because "ubuntu-latest" failed.
Test on windows-latest
The operation was canceled.
Build target wasm32-wasi
failed to select a version for the requirement `ahash = "^0.7"`
Build target wasm32-wasi
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Code coverage
Broken pipe (os error 32)
Code coverage
could not compile `zcash_primitives` (lib) due to 9 previous errors; 1 warning emitted
Code coverage: zcash_primitives/src/transaction/components/sapling.rs#L462
no function or associated item named `from_bytes_wide` found for struct `Fq` in the current scope
Code coverage
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
unused import: `GroupEncoding`: zcash_primitives/src/transaction/components/sapling.rs#L427
warning: unused import: `GroupEncoding` --> zcash_primitives/src/transaction/components/sapling.rs:427:24 | 427 | use group::{Group, GroupEncoding}; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
usage of `mem::size_of::<T>()` to obtain the size of `T` in bits: components/equihash/src/verify.rs#L224
warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:224:23 | 224 | let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits
usage of `mem::size_of::<T>()` to obtain the size of `T` in bits: components/equihash/src/verify.rs#L173
warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:173:13 | 173 | assert!(8 * size_of::<u32>() >= 7 + bit_len); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits = note: `-W clippy::manual-bits` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`
manually reimplementing `div_ceil`: components/f4jumble/src/lib.rs#L182
warning: manually reimplementing `div_ceil` --> components/f4jumble/src/lib.rs:182:5 | 182 | (num + den - 1) / den | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num.div_ceil(den)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `-W clippy::manual-div-ceil` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_div_ceil)]`
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Intra-doc links
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test on ubuntu-latest
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (1.56.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (1.56.1)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Clippy (1.56.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (1.56.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (1.56.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (1.56.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build target wasm32-wasi
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Code coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code coverage
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/