Skip to content
CI checks

update bip0039 to resolve dependency conflicts with downstream consum… #10

Sign in to view logs

update bip0039 to resolve dependency conflicts with downstream consum…

update bip0039 to resolve dependency conflicts with downstream consum… #10

GitHub Actions / Clippy (beta) failed Oct 16, 2024 in 0s

Clippy (beta)

8 errors, 4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 8
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0-beta.1 (0125edf41 2024-10-14)
  • cargo 1.83.0-beta.1 (15fbd2f60 2024-10-08)
  • clippy 0.1.83 (0125edf 2024-10-14)

Annotations

Check warning on line 427 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `GroupEncoding` 

warning: unused import: `GroupEncoding`
   --> zcash_primitives/src/transaction/components/sapling.rs:427:24
    |
427 |     use group::{Group, GroupEncoding};
    |                        ^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

Check failure on line 110 in zcash_primitives/src/sapling/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> zcash_primitives/src/sapling/prover.rs:110:73
    |
110 |                 PublicKey(proof_generation_key.ak.into()).randomize(ar, SPENDING_KEY_GENERATOR);
    |                                                           ---------     ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR`
    |                                                           |
    |                                                           arguments to this method are incorrect
    |
note: method defined here
   --> zcash_primitives/src/sapling/redjubjub.rs:105:12
    |
105 |     pub fn randomize(&self, alpha: jubjub::Fr, p_g: SubgroupPoint) -> Self {
    |            ^^^^^^^^^                           ------------------
help: consider dereferencing the type
    |
110 |                 PublicKey(proof_generation_key.ak.into()).randomize(ar, *SPENDING_KEY_GENERATOR);
    |                                                                         +

Check failure on line 530 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> zcash_primitives/src/transaction/components/sapling.rs:530:102
    |
530 | ...rized { binding_sig: bsk.sign(&fake_bvk_bytes, &mut rng, VALUE_COMMITMENT_RANDOMNESS_GENERATOR) },
    |                             ----                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `VALUE_COMMITMENT_RANDOMNESS_GENERATOR`
    |                             |
    |                             arguments to this method are incorrect
    |
note: method defined here
   --> zcash_primitives/src/sapling/redjubjub.rs:74:12
    |
74  |     pub fn sign<R: RngCore>(&self, msg: &[u8], rng: &mut R, p_g: SubgroupPoint) -> Signature {
    |            ^^^^                                             ------------------
help: consider dereferencing the type
    |
530 |                         authorization: Authorized { binding_sig: bsk.sign(&fake_bvk_bytes, &mut rng, *VALUE_COMMITMENT_RANDOMNESS_GENERATOR) },
    |                                                                                                      +

Check failure on line 491 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope 

error[E0599]: no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope
   --> zcash_primitives/src/transaction/components/sapling.rs:491:47
    |
491 |                 .prop_map(|v| blstrs::Scalar::from_bytes_wide(&v)),
    |                                               ^^^^^^^^^^^^^^^ function or associated item not found in `jubjub::Fq`
    |
help: there is an associated function `from_bytes_be` with a similar name
    |
491 |                 .prop_map(|v| blstrs::Scalar::from_bytes_be(&v)),
    |                                               ~~~~~~~~~~~~~

Check failure on line 479 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> zcash_primitives/src/transaction/components/sapling.rs:479:73
    |
479 |                 spend_auth_sig: sk1.sign(&fake_sighash_bytes, &mut rng, SPENDING_KEY_GENERATOR),
    |                                     ----                                ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR`
    |                                     |
    |                                     arguments to this method are incorrect
    |
note: method defined here
   --> zcash_primitives/src/sapling/redjubjub.rs:74:12
    |
74  |     pub fn sign<R: RngCore>(&self, msg: &[u8], rng: &mut R, p_g: SubgroupPoint) -> Signature {
    |            ^^^^                                             ------------------
help: consider dereferencing the type
    |
479 |                 spend_auth_sig: sk1.sign(&fake_sighash_bytes, &mut rng, *SPENDING_KEY_GENERATOR),
    |                                                                         +

Check failure on line 637 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proptest-1.5.0/src/sugar.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the size for values of type `[u8]` cannot be known at compilation time 

error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
   --> zcash_primitives/src/transaction/components/sapling.rs:455:5
    |
455 | /     prop_compose! {
456 | |         /// produce a spend description with invalid data (useful only for serialization
457 | |         /// roundtrip testing).
458 | |         fn arb_spend_description()(
...   |
481 | |         }
482 | |     }
    | |_____^ doesn't have a size known at compile-time
    |
    = help: within `(jubjub::ExtendedPoint, jubjub::Fq, sapling::Nullifier, _, [u8; 32], [u8])`, the trait `std::marker::Sized` is not implemented for `[u8]`, which is required by `(_, _, _, _, _, _): std::marker::Sized`
    = note: required because it appears within the type `(jubjub::ExtendedPoint, jubjub::Fq, sapling::Nullifier, _, [u8; 32], [u8])`
    = note: all function arguments must have a statically known size
    = note: this error originates in the macro `prop_compose` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 468 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the size for values of type `[u8]` cannot be known at compilation time 

error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
   --> zcash_primitives/src/transaction/components/sapling.rs:468:13
    |
468 |             fake_sighash_bytes in prop::array::uniform32(prop::num::u8::ANY),
    |             ^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `[u8]`
    = note: all local variables must have a statically known size
    = help: unsized locals are gated as an unstable feature

Check failure on line 472 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> zcash_primitives/src/transaction/components/sapling.rs:472:52
    |
472 |             let rk = PublicKey::from_private(&sk1, SPENDING_KEY_GENERATOR);
    |                      -----------------------       ^^^^^^^^^^^^^^^^^^^^^^ expected `SubgroupPoint`, found `SPENDING_KEY_GENERATOR`
    |                      |
    |                      arguments to this function are incorrect
    |
note: associated function defined here
   --> zcash_primitives/src/sapling/redjubjub.rs:100:12
    |
100 |     pub fn from_private(privkey: &PrivateKey, p_g: SubgroupPoint) -> Self {
    |            ^^^^^^^^^^^^                       ------------------
help: consider dereferencing the type
    |
472 |             let rk = PublicKey::from_private(&sk1, *SPENDING_KEY_GENERATOR);
    |                                                    +

Check failure on line 462 in zcash_primitives/src/transaction/components/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope 

error[E0599]: no function or associated item named `from_bytes_wide` found for struct `jubjub::Fq` in the current scope
   --> zcash_primitives/src/transaction/components/sapling.rs:462:47
    |
462 |                 .prop_map(|v| blstrs::Scalar::from_bytes_wide(&v)),
    |                                               ^^^^^^^^^^^^^^^ function or associated item not found in `jubjub::Fq`
    |
help: there is an associated function `from_bytes_be` with a similar name
    |
462 |                 .prop_map(|v| blstrs::Scalar::from_bytes_be(&v)),
    |                                               ~~~~~~~~~~~~~

Check warning on line 224 in components/equihash/src/verify.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `mem::size_of::<T>()` to obtain the size of `T` in bits 

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits
   --> components/equihash/src/verify.rs:224:23
    |
224 |     let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1);
    |                       ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits

Check warning on line 173 in components/equihash/src/verify.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `mem::size_of::<T>()` to obtain the size of `T` in bits 

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits
   --> components/equihash/src/verify.rs:173:13
    |
173 |     assert!(8 * size_of::<u32>() >= 7 + bit_len);
    |             ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits
    = note: `-W clippy::manual-bits` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`

Check warning on line 182 in components/f4jumble/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manually reimplementing `div_ceil` 

warning: manually reimplementing `div_ceil`
   --> components/f4jumble/src/lib.rs:182:5
    |
182 |     (num + den - 1) / den
    |     ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num.div_ceil(den)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
    = note: `-W clippy::manual-div-ceil` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::manual_div_ceil)]`
View more details on GitHub Actions