Open
Conversation
This library is much faster. In addition, it replaces _many_ packages which provide similar functionality outside of this repo. By using it here, we will benefit from npm's de-duplication on install because of that (e.g. in Netlify we dropped 6 packages to use this 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library is much faster. In addition, it replaces many packages
which provide similar functionality outside of this repo. By using it
here, we will benefit from npm's de-duplication on install because of
that (e.g. in Netlify we dropped 6 packages to use this 1).
@coreyfarrell this repo seems to be in dire need of some TLC. I can't run tests anymore all the way back to Node 16 on MacOS.
Locally, I did mess around with the dependencies and see a passing test run.
Would you be open to us dropping tap, using
node --test? We should be able to make that switch pretty easily.