Open
Conversation
Author
|
I'm also fine if this other PR gets merged instead: #24 which fixes more issues present in this repo that I did mention above as well. |
|
I looking for this PR to merge, as there is security vulnerability raised in prod envs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets start with the obvious upgrade, the
js-yamlsecurity vulnerability (production dependency).I tried running the test.. Gave error (I think I blame
xofrom thepreteststep?):But also
tapwon't run anymore...Also you can use
fs.readFileSynctoday, instead of wrapping it inpromisify😨 .Fixes: #22