Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pmd and spotbugs gateway #175

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

simonhir
Copy link
Member

Description

Add PMD and Spotbugs for refarch-gateway and fix warnings.

References
Issue #57, #58

@simonhir simonhir self-assigned this Sep 20, 2024
Copy link
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ❌ 1 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
See the Details below.

License Issues

refarch-gateway/pom.xml

PackageVersionLicenseIssue Type
com.h3xstream.findsecbugs:findsecbugs-plugin1.13.0LGPL-3.0Incompatible License
Denied Licenses: GPL-1.0-or-later, LGPL-2.0-or-later, AGPL-1.0-or-later
Excluded from license check: pkg:npm/escape-string-regexp, pkg:npm/path-exists, pkg:npm/slash, pkg:npm/yocto-queue, pkg:npm/load-script, pkg:npm/node-forge, pkg:maven/com.puppycrawl.tools/checkstyle, pkg:maven/com.hazelcast/hazelcast-spring

OpenSSF Scorecard

PackageVersionScoreDetails
maven/com.github.spotbugs:spotbugs-maven-plugin 4.8.6.2 🟢 5.6
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 0Found 0/11 approved changesets -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Fuzzing⚠️ 0project is not fuzzed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy⚠️ 0security policy file not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Packaging🟢 10packaging workflow detected
SAST🟢 10SAST tool is run on all commits
Vulnerabilities🟢 82 existing vulnerabilities detected
maven/com.h3xstream.findsecbugs:findsecbugs-plugin 1.13.0 🟢 5.5
Details
CheckScoreReason
Code-Review🟢 9Found 11/12 approved changesets -- score normalized to 9
Maintained🟢 66 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 6
CII-Best-Practices⚠️ 2badge detected: InProgress
License🟢 10license file detected
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 9security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
SAST🟢 8SAST tool detected but not run on all commits
Vulnerabilities🟢 100 existing vulnerabilities detected
maven/org.apache.maven.plugins:maven-pmd-plugin 3.25.0 UnknownUnknown

Scanned Manifest Files

refarch-gateway/pom.xml

@github-actions github-actions bot added Component: API-Gateway Issues regarding the API Gateway Type: Feature The issue is a feature labels Sep 20, 2024
@simonhir simonhir marked this pull request as ready for review September 20, 2024 07:14
@simonhir simonhir requested a review from a team as a code owner September 20, 2024 07:14
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit e188593 into main Sep 20, 2024
11 checks passed
@simonhir simonhir deleted the feature/pmd-and-spotbugs-gateway branch September 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: API-Gateway Issues regarding the API Gateway Type: Feature The issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants