Skip to content

Conversation

@2bbodia
Copy link
Collaborator

@2bbodia 2bbodia commented May 26, 2022

Renamed modals(login and recover password), action, and reducer for login modal
Rewrite LoginModal( it is no longer rendering the button)
Added separate component which renders header button
Moved connect to redux from landing to landing wrapper
Moved LoginModal to MainLayout
Updated all paths

dev

GitHub Project

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • PR is reviewed manually again (to make sure you have 100% ready code)
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

…in modal

Rewrite LoginModal( it is no longer rendering the button)
Added separate component which render header button
Moved connent to redux from landing to landing wrapper
Moved LoginModal to MainLayout
Updated all paths
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants